Potential fix for Delicious addLink error #55
Conversation
…is is bc the API is failing on addLink calls when crazy chars are found in the description field (pulled from title value). domainersuitedev/delicious-api#22
…hars. This is bc the API is failing on addLink calls when crazy chars are found in the description field (pulled from title value). domainersuitedev/delicious-api#22" This reverts commit 8677690.
filter any non-ascii chars from the title value, because Delicious does not handle non-ascii chars well. Returns error on POST to addLink
|
This looks good man, can you provide me with something I can test with to make sure it didnt break anything else? Maybe a page that has ascii characters? Thanks again for your help, I need to also make sure its pushed into version 3, but I can handle that manually. |
|
Glad to help out. Last known 'problem' URL (now saving): http://me.dt.in.th/page/JavaScript-override/ I can make some time in the next few weeks to help beta test v3, if you're interested. |
Potential fix for Delicious addLink error
|
Ok, so this does work, but I don't see it as a long term fix. If you go to Delicious.com and add the links they work fine, there is something missing when sending it to the API. I am digging into it now. Cheers. |
|
Agreed. As another test, when I double-encode the value from the extension's POST call, then Delicious will save the value properly, and even display the 'star' character on their site. However, then the extension is double-encoding the value, and the 'my links' view displays the encoded value. Ugh. Outside of fixing the temporary filter, it looks like we may need to add non-ascii detection and either:
Thanks for hearing me out. Least I can do is buy you a beer this summer. |
|
@mmerriam, I just pushed up my changes. I through it into a function that can be expanded upon later. Using this page as an example. I didn't that it was removing the ö and ä. I found the translation of that on stack overflow. Go ahead and pull down the latest from |
|
I just thought of something, this will break it for other languages. https://ja.wikipedia.org/wiki/%E4%B8%96%E7%95%8C%E9%81%BA%E7%94%A3 If you try to save that it removes all the Japanese characters, thats not cool. |
|
I agree. |
Sorry it took so long, but I just started a new job this week, and my sublime JS beautifier plugin made an initial mess of the original code.
This may not fix everyone's recent problems, but after stepping through the code, I noticed that all requests to the Delicious API with non-ascii chars (in the description field, from the HTML title) were getting rejected.
All I did was put a regex filter on it. So far, I haven't had any difficulty saving links anymore.
Also, my git skills are lacking and I couldn't figure out how to squash the earlier commit (which included all the JS beautifier adjustments), so I just reverted the initial change (5/21).
Thanks.